Messages in this thread | | | Date | Sat, 19 May 2012 22:50:54 +0530 | From | Laxman Dewangan <> | Subject | Re: [PATCH] regulator: core: use correct device for device supply lookup |
| |
On Saturday 19 May 2012 10:44 PM, Laxman Dewangan wrote: > On Saturday 19 May 2012 10:11 PM, Mark Brown wrote: >> * PGP Signed by an unknown key >> >> On Sat, May 19, 2012 at 07:44:06PM +0530, Laxman Dewangan wrote: >>> When registering the regulator driver, use the rdev->dev for >>> getting the regulator device of given supply instead of parent >>> device. >> You're providing no motivation for this and it's difficult to see how it >> improves things. The class device is dynamically numbered so it's not >> suitable for specifying supplies on a non-DT system and for a DT system >> it's not obvious to me that we would want to involve the class device in >> anything, it requires an additional layer of indirection but that's >> about it. > If I dont do this then it will not enter in the following case for > getting the regulator_dev of supply regulator because dev->of_node is > null, the tps65910-regulator driver have not set the pdev->dev.ofnode. > > static struct regulator_dev *regulator_dev_lookup(struct device *dev, > const char *supply, > int *ret) > { > /* first do a dt based lookup */ > if (dev&& dev->of_node) { > :::::::::::::::: > /* Get the regulator device */ > > } > :::::::::::::::::: > } Also in regulator_register we set the of_node as rdev->dev.of_node = config->of_node; rdev->dev.parent = dev;
Passed config->of_node will only be used if we pass the rdev->dev, not rdev->dev.parent
Am I missing anything here in understanding?
| |