Messages in this thread | | | Subject | Re: [PATCH 1/2] perf: Add persistent event facilities | From | Peter Zijlstra <> | Date | Fri, 18 May 2012 12:14:00 +0200 |
| |
On Wed, 2012-03-21 at 15:34 +0100, Borislav Petkov wrote: > +int perf_add_persistent_on_cpu(int cpu, struct pers_event_desc *desc, > + struct dentry *dir, unsigned nr_pages)
OK, so this creates an even and registers it somewhere in debugfs.
- you allow an arbitrary place in debugfs; this might make finding them 'interesting'. Should we put them all in the same place?
- persistent events created from userspace don't seem to get a debugfs entry and will be lost forever?
In general I think a little more exploring of the semantics and ramifications might be in order.
| |