lkml.org 
[lkml]   [2012]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 18/54] sungem: Fix WakeOnLan
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------


    From: Gerard Lledo <gerard.lledo@gmail.com>

    [ Upstream commit 5a8887d39e1ba5ee2d4ccb94b14d6f2dce5ddfca ]

    WakeOnLan was broken in this driver because gp->asleep_wol is a 1-bit
    bitfield and it was being assigned WAKE_MAGIC, which is (1 << 5).
    gp->asleep_wol remains 0 and the machine never wakes up. Fixed by casting
    gp->wake_on_lan to bool. Tested on an iBook G4.

    Signed-off-by: Gerard Lledo <gerard.lledo@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/sungem.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/sungem.c
    +++ b/drivers/net/sungem.c
    @@ -2363,7 +2363,7 @@ static int gem_suspend(struct pci_dev *p
    netif_device_detach(dev);

    /* Switch off MAC, remember WOL setting */
    - gp->asleep_wol = gp->wake_on_lan;
    + gp->asleep_wol = !!gp->wake_on_lan;
    gem_do_stop(dev, gp->asleep_wol);
    } else
    gp->asleep_wol = 0;



    \
     
     \ /
      Last update: 2012-05-19 02:01    [W:4.134 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site