Messages in this thread | | | Subject | Re: [PATCH v6 3/3] gpio: TS-5500 GPIO support | From | Vivien Didelot <> | Date | Thu, 17 May 2012 17:40:26 -0400 |
| |
On Thu, 2012-05-17 at 15:06 -0600, Grant Likely wrote: > > arch/x86/include/asm/ts5500.h | 62 ++++++++ > > Why the separate header file? What will use these defines? I > normally expect driver-specific defines to be in the driver .c file > directly; particularly for things like gpio drivers which should be a > generic interface that doesn't need to export symbols.
Should an intermediate driver directly use values for GPIOs instead of these symbols? For example, how should a temperature sensor plugged on this platform refer to inputs and outputs?
Thanks, Vivien
| |