Messages in this thread | | | Subject | Re: [PATCH v3 03/17] powerpc: Add PFO support to the VIO bus | From | Benjamin Herrenschmidt <> | Date | Mon, 14 May 2012 10:32:07 +1000 |
| |
On Fri, 2012-05-11 at 07:58 +1000, Benjamin Herrenschmidt wrote: > > > > Having the timeout and retries in this function is the wrong thing to do. > > We'll resubmit this without the loop and the caller will be responsible for > > retrying the operations. > > > > I would rather have the caller cede the processor or alter thread > > priority where appropriate than doing that in this function. I don't > > think this should be done in this crypto driver. > > That sounds right indeed... as long as the upper crypto layer has a > concept of "try again later"... if it doesn't it will result in random > funny failures :-)
Ping ?
So I'm merging 1 to 5 (ie, up to and including the hwrng driver). I will still merge the rest if you send a fix for that in the next day or so but not much longer.
Cheers, Ben.
| |