lkml.org 
[lkml]   [2012]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] irq: use config_enabled(SMP) checks to cleanup irq_set_affinity() for UP

* Suresh Siddha <suresh.b.siddha@intel.com> wrote:

> On Wed, 2012-05-09 at 11:46 -0700, Suresh Siddha wrote:
> > Use config_enabled(SMP) checks for cleaning up the ifdef CONFIG_SMP around
> > irq_set_affinity routines in io_apic and irq_remapping subsystems.
> >
>
> Switched to IS_BUILTIN() instead. Thanks.

Hm, what was wrong with config_enabled(CONFIG_SMP)?

The IS_BUILTIN() macro is 1) shouting loud, needlessly 2)
somewhat confusing for the CONFIG_SMP case: of course SMP is
'built in', not modular - and the fact that 'built in' also
implies 'enabled' is lost in that naming variant.

So I think IS_BUILTIN() makes more sense for genuine tri-state
config knobs, and bools like CONFIG_SMP should se
config_enabled()..

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-05-10 10:21    [W:4.070 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site