Messages in this thread | | | Date | Thu, 10 May 2012 09:50:31 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 2/2] irq: use config_enabled(SMP) checks to cleanup irq_set_affinity() for UP |
| |
* Suresh Siddha <suresh.b.siddha@intel.com> wrote:
> On Wed, 2012-05-09 at 11:46 -0700, Suresh Siddha wrote: > > Use config_enabled(SMP) checks for cleaning up the ifdef CONFIG_SMP around > > irq_set_affinity routines in io_apic and irq_remapping subsystems. > > > > Switched to IS_BUILTIN() instead. Thanks.
Hm, what was wrong with config_enabled(CONFIG_SMP)?
The IS_BUILTIN() macro is 1) shouting loud, needlessly 2) somewhat confusing for the CONFIG_SMP case: of course SMP is 'built in', not modular - and the fact that 'built in' also implies 'enabled' is lost in that naming variant.
So I think IS_BUILTIN() makes more sense for genuine tri-state config knobs, and bools like CONFIG_SMP should se config_enabled()..
Thanks,
Ingo
| |