Messages in this thread | | | Subject | Re: [PATCH] net: orphan queued skbs if device tx can stall | From | Eric Dumazet <> | Date | Mon, 09 Apr 2012 11:13:29 +0200 |
| |
On Mon, 2012-04-09 at 11:42 +0300, Michael S. Tsirkin wrote: > On Mon, Apr 09, 2012 at 04:39:58PM +0800, Herbert Xu wrote: > > On Mon, Apr 09, 2012 at 11:34:02AM +0300, Michael S. Tsirkin wrote: > > > > > > Puzzled. This patch orphans skbs only if the destination device sets > > > IFF_TX_CAN_STALL. Since the physical NIC doesn't stall forever it never > > > sets this flag. > > > > > > So it seems that this patch should not affect the configuration > > > you describe at all. > > > > > > Could you please clarify? What did I miss? > > > > Oops, you're right. Somehow I was thinking you were patching > > virtio-net instead of tun. > > > > Cheers, > > Cool. Want to ack the patch then just to make it clear you are happy?
I am not happy with this patch.
Since its Easter, I dont have much time to comment right now, I'll do that tomorrow.
| |