Messages in this thread Patch in this message | | | Date | Mon, 9 Apr 2012 22:51:41 +0200 (CEST) | From | Jesper Juhl <> | Subject | [PATCH 19/26] [SCSI] qla2xxx: Remove redundant NULL check before release_firmware() call. |
| |
release_firmware() checks for NULL pointers internally so checking before calling it is redundant.
Signed-off-by: Jesper Juhl <jj@chaosbits.net> --- drivers/scsi/qla2xxx/qla_os.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index a2f9992..91b6fe6 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -4106,8 +4106,7 @@ qla2x00_release_firmware(void) mutex_lock(&qla_fw_lock); for (idx = 0; idx < FW_BLOBS; idx++) - if (qla_fw_blobs[idx].fw) - release_firmware(qla_fw_blobs[idx].fw); + release_firmware(qla_fw_blobs[idx].fw); mutex_unlock(&qla_fw_lock); } -- 1.7.10
-- Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please.
| |