lkml.org 
[lkml]   [2012]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 25/69] TTY: con3215, remove tasklet for tty_wakeup
    On 04/09/2012 08:27 PM, Greg KH wrote:
    > On Tue, Apr 03, 2012 at 09:59:19AM +0200, Jiri Slaby wrote:
    >> On 04/03/2012 07:42 AM, Heiko Carstens wrote:
    >>> On Mon, Apr 02, 2012 at 01:54:09PM +0200, Jiri Slaby wrote:
    >>>> tty_wakeup is safe to be called from all contexts. No need to schedule
    >>>> a tasklet for that. Let us call it directly like in other drivers.
    >>>>
    >>>> And delete the tasklet completely.
    >>>
    >>> Your patch actually reverts Martin's recent commit 656d912537
    >>> "[S390] 3215 deadlock with tty_wakeup".
    >>> I'm quite sure the reason for the deadlock still exists.
    >>> Unfortunately the commit doesn't contain the call chain that
    >>> led to fix.
    >>
    >> Ok, I would really appreciate the trace.
    >>
    >> If this is really an issue, we should provide a helper in the TTY layer
    >> like tty_schedule_wakeup.
    >
    > Jiri, should I not apply this patch?

    Yes, please skip it until this is sorted out. And also the other con3215
    patches if they don't apply cleanly now.

    thanks,
    --
    js
    suse labs




    \
     
     \ /
      Last update: 2012-04-09 20:33    [W:2.616 / U:0.872 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site