Messages in this thread | | | Date | Mon, 9 Apr 2012 07:07:15 -0700 | Subject | Re: [PATCH] video: exynos: fix build warning and bad pointer deref in dp driver | From | Olof Johansson <> |
| |
On Mon, Apr 9, 2012 at 2:25 AM, Jingoo Han <jg1.han@samsung.com> wrote: >> -----Original Message----- >> From: Olof Johansson [mailto:olof@lixom.net] >> Sent: Monday, April 09, 2012 1:16 PM >> >> I'm not 100% sure if the fix for 'adjust_request' is correct, since >> it's uncertain what the original intent was. But it's so clearly an >> uninitialized pointer dereference that my resolution seems to make sense. >> >> drivers/video/exynos/exynos_dp_core.c: In function 'exynos_dp_set_link_train': >> drivers/video/exynos/exynos_dp_core.c:521:21: warning: 'adjust_request' may be used uninitialized in >> this function [-Wuninitialized] >> drivers/video/exynos/exynos_dp_core.c:481:6: note: 'adjust_request' was declared here >> drivers/video/exynos/exynos_dp_core.c:529:18: warning: 'reg' may be used uninitialized in this function >> [-Wuninitialized] >> drivers/video/exynos/exynos_dp_core.c:395:6: note: 'reg' was declared here > > My compiler cannot detect this warning. > What is your compiler version?
gcc version 4.6.2 (GCC)
-Olof
| |