Messages in this thread | | | Date | Sun, 8 Apr 2012 21:46:28 -0400 | Subject | Re: [PATCH] media: au0828: Convert BUG_ON to WARN_ONCE | From | Devin Heitmueller <> |
| |
On Sun, Apr 8, 2012 at 7:19 PM, Larry Finger <Larry.Finger@lwfinger.net> wrote: > In the mail thread at http://www.mythtv.org/pipermail/mythtv-users/2012-April/331164.html, > a kernel crash is triggered when trying to run mythtv with a HVR950Q tuner. > The crash condition is due to res_free() being called to free something that > has is not reserved. The actual reason for this mismatch of reserve/free is > not known; however, using a BUG_ON rather than a WARN_ON seems unfortunate.
This patch should be nack'd. The real reason should be identified, and a patch should be submitted for that (and from what I gather, it seems like it is easily reproduced by the submitter). Just add a few "dump_stack()" calls in the res_get() and res_free() calls to identify the failing call path.
Devin
-- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com
| |