Messages in this thread | | | Date | Sat, 7 Apr 2012 12:10:39 +0200 | From | Hans-Christian Egtvedt <> | Subject | Re: [PATCH v2] avr32: fix nop compile fails from system.h split up |
| |
Around Tue 03 Apr 2012 19:14:04 -0400 or thereabout, Paul Gortmaker wrote: > To fix: > > In file included from kernel/exit.c:61: > arch/avr32/include/asm/mmu_context.h: In function 'enable_mmu': > arch/avr32/include/asm/mmu_context.h:135: error: implicit > declaration of function 'nop' > > It needs an include of the new file created in: > > commit ae473946586680b01c13975a3b674de23ad7c93e > > "Disintegrate asm/system.h for AVR32" > > But since that file only contains "nop", and since other > arch already have precedent of putting nop in asm/barrier.h > we should just delete the new file and put nop in barrier.h
Sounds fine by me, thanks for the fix.
> Suggested-by: David Howells <dhowells@redhat.com> > Cc: Haavard Skinnemoen <hskinnemoen@gmail.com> > Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
<snipp diff>
-- mvh Hans-Christian Egtvedt
| |