lkml.org 
[lkml]   [2012]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT pull] timer updates for 3.4-rc
On Sat, 7 Apr 2012, Thomas Gleixner wrote:

> diff --git a/kernel/itimer.c b/kernel/itimer.c
> index 22000c3..c70369a 100644
> --- a/kernel/itimer.c
> +++ b/kernel/itimer.c
> @@ -284,8 +284,11 @@ SYSCALL_DEFINE3(setitimer, int, which, struct itimerval __user *, value,
> if (value) {
> if(copy_from_user(&set_buffer, value, sizeof(set_buffer)))
> return -EFAULT;
> - } else
> + } else {
> memset((char *) &set_buffer, 0, sizeof(set_buffer));
> + WARN_ONCE(1, "setitimer: new_value pointer is NULL."
> + " Misfeature support will be removed\n");
> + }
>
> error = do_setitimer(which, &set_buffer, ovalue ? &get_buffer : NULL);
> if (error || !ovalue)

When I tried doing this for the deprecated /proc/pid/oom_adj there was a
complaint that WARN_ONCE() screws up log parsing scripts that think there
is a kernel issue so I had to change it to printk_once() and include
get_task_comm(current) and current->pid. See
http://lkml.indiana.edu/hypermail/linux/kernel/1108.0/00446.html


\
 
 \ /
  Last update: 2012-04-07 01:41    [W:0.037 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site