lkml.org 
[lkml]   [2012]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] hugetlb: fix race condition in hugetlb_fault()
On Fri, 6 Apr 2012, Andrew Morton wrote:
> On Sun, 1 Apr 2012 12:51:49 -0400
> Chris Metcalf <cmetcalf@tilera.com> wrote:
>
> > >> Cc: stable@kernel.org
> > > Let Andrew do the stable work, ok?
> >
> > Fair point. I'm used to adding the Cc myself for things I push through the
> > arch/tile tree. This of course does make more sense to go through Andrew,
> > so I'll remove it.
>
> No, please do add the stable tag if you think it is needed. And ensure
> that the changelog explains why a backport is needed, by describing
> the user-visible effects of the bug.
>
> Tree-owners regularly forget to wonder if a patch should be backported
> and we end up failing to backport patches which should have been
> backported. If we have more people flagging backport patches, fewer
> patches will fall through the cracks.

The resulting patch is okay; but let's reassure Chris that his
original patch was better, before he conceded to make the get_page
and put_page unconditional, and added unnecessary detail of the race.

Hugh


\
 
 \ /
  Last update: 2012-04-07 01:13    [W:0.047 / U:2.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site