Messages in this thread | | | Date | Fri, 6 Apr 2012 10:59:15 -0400 | From | Kyle McMartin <> | Subject | Re: [PATCH 25/40] parisc: Use set_current_blocked() and block_sigmask() |
| |
On Tue, Feb 14, 2012 at 11:40:58AM +0000, Matt Fleming wrote: > From: Matt Fleming <matt.fleming@intel.com> > > As described in e6fa16ab ("signal: sigprocmask() should do > retarget_shared_pending()") the modification of current->blocked is > incorrect as we need to check whether the signal we're about to block > is pending in the shared queue. > > Also, use the new helper function introduced in commit 5e6292c0f28f > ("signal: add block_sigmask() for adding sigmask to current->blocked") > which centralises the code for updating current->blocked after > successfully delivering a signal and reduces the amount of duplicate > code across architectures. In the past some architectures got this > code wrong, so using this helper function should stop that from > happening again. > > Cc: Oleg Nesterov <oleg@redhat.com> > Cc: Kyle McMartin <kyle@mcmartin.ca> > Cc: Helge Deller <deller@gmx.de> > Cc: "James E.J. Bottomley" <jejb@parisc-linux.org> > Cc: linux-parisc@vger.kernel.org > Signed-off-by: Matt Fleming <matt.fleming@intel.com>
Nice cleanups Matt!
Acked-by: Kyle McMartin <kyle@mcmartin.ca>
| |