Messages in this thread Patch in this message | | | From | Venkatraman S <> | Subject | [PATCH 2/2] scsi/ufs: Fix evaluation of task_failed status | Date | Fri, 6 Apr 2012 10:57:09 +0530 |
| |
Else FAILED would be set even if task_result was originally equal to UPIU_TASK_MANAGEMENT_FUNC_SUCCEEDED.
Reported-by: Joe Perches <joe@perches.com> Signed-off-by: Venkatraman S <svenkatr@ti.com> CC: Santosh Y <santoshsy@gmail.com> CC: Andrew Morton <akpm@linux-foundation.org> --- drivers/scsi/ufs/ufshcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index aa97200..cd59f6f 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -1160,7 +1160,7 @@ static int ufshcd_task_req_compl(struct ufs_hba *hba, u32 index) task_result = be32_to_cpu(task_rsp_upiup->header.dword_1); task_result = ((task_result & MASK_TASK_RESPONSE) >> 8); - if (task_result != UPIU_TASK_MANAGEMENT_FUNC_COMPL || + if (task_result != UPIU_TASK_MANAGEMENT_FUNC_COMPL && task_result != UPIU_TASK_MANAGEMENT_FUNC_SUCCEEDED) task_result = FAILED; } else { -- 1.7.5.4
| |