Messages in this thread | | | Date | Fri, 06 Apr 2012 16:10:29 +0400 | From | Sergei Shtylyov <> | Subject | Re: [PATCH 1/1] [v3] Add support 2 SATA ports for Maui and change filename from sata_dwc_460ex.c to sata_dwc_4xx.c |
| |
Hello.
On 06-04-2012 9:31, Thang Q. Nguyen wrote:
> Signed-off-by: Thang Q. Nguyen<tqnguyen@apm.com> > --- > Changes for v2: > - Use git rename feature to change the driver to the newname and for > easier review.
> Changes for v3: > - Remove materials not related to 2 SATA ports support. They will > be added in another patches.
> drivers/ata/Makefile | 2 +- > drivers/ata/{sata_dwc_460ex.c => sata_dwc_4xx.c} | 820 +++++++++++----------- > 2 files changed, 430 insertions(+), 392 deletions(-) > rename drivers/ata/{sata_dwc_460ex.c => sata_dwc_4xx.c} (73%)
> diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_4xx.c > similarity index 73% > rename from drivers/ata/sata_dwc_460ex.c > rename to drivers/ata/sata_dwc_4xx.c > index 69f7cde..07e9b36 100644 > --- a/drivers/ata/sata_dwc_460ex.c > +++ b/drivers/ata/sata_dwc_4xx.c [...] > @@ -16,6 +14,15 @@ > * under the terms of the GNU General Public License as published by the > * Free Software Foundation; either version 2 of the License, or (at your > * option) any later version. > + * > + * CHANGES: > + * - Version 1.4: > + * + Change filename from sata_dwc_460ex.c to sata_dwc_4xx.c > + * + This driver supports more than one SATA port. Each SATA port has its > + * own private attribute. Move sata_dwc_host_priv structure to > + * sata_dwc_device and sata_dwc_device_port structures. > + * + Change to use ata_bmdma_qc_issue and ata_bmdma_error_handler because > + * the ata_sff_qc_issue and ata_sff_error_handler no longer support DMA.
This modification looks like a bug fix, and so should be separated and posted before the dual-port patch.
I'll try to do more deltailed review on the weekend.
MBR, Sergei
| |