lkml.org 
[lkml]   [2012]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/1] bonding: properly unset current_arp_slave on slave link up
Date
Veaceslav Falico <vfalico@redhat.com> wrote:

>When a slave comes up, we're unsetting the current_arp_slave without
>removing active flags from it, which can lead to situations where we have
>more than one slave with active flags in active-backup mode.
>
>To avoid this situation we must remove the active flags from a slave before
>removing it as a current_arp_slave.
>
>Signed-off-by: Veaceslav Falico <vfalico@redhat.com>

Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>

>---
>diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>index 0c76186..ad731a1 100644
>--- a/drivers/net/bonding/bond_main.c
>+++ b/drivers/net/bonding/bond_main.c
>@@ -3001,7 +3001,11 @@ static void bond_ab_arp_commit(struct bonding *bond, int delta_in_ticks)
> trans_start + delta_in_ticks)) ||
> bond->curr_active_slave != slave) {
> slave->link = BOND_LINK_UP;
>- bond->current_arp_slave = NULL;
>+ if (bond->current_arp_slave) {
>+ bond_set_slave_inactive_flags(
>+ bond->current_arp_slave);
>+ bond->current_arp_slave = NULL;
>+ }
>
> pr_info("%s: link status definitely up for interface %s.\n",
> bond->dev->name, slave->dev->name);
>



\
 
 \ /
  Last update: 2012-04-05 18:45    [W:0.950 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site