Messages in this thread | | | Date | Thu, 05 Apr 2012 11:36:33 +0600 | From | Mike Sinkovsky <> | Subject | Re: [PATCH v8 0/2] Ethernet drivers for WIZnet chips |
| |
05.04.2012 7:15, David Miller wrote: > From: Mike Sinkovsky<msink@trikom.ru> > Date: Wed, 4 Apr 2012 17:57:38 +0600 > >> From: Mike Sinkovsky<msink@permonline.ru> >> >> Based on original driver from chip manufacturer, but nearly full rewite. >> Tested and used in production with Blackfin BF531 embedded processor. >> >> Signed-off-by: Mike Sinkovsky<msink@permonline.ru> > > I don't see the appropriate changes in your patches to make > sure that drivers/net/ethernet/{Kconfig,Makefile} consider > and traverse down into the wiznet/ subdirectory. > > Furthermore, once that is fixed these drivers generate warnings > when built: > > drivers/net/ethernet/wiznet/w5300.c:708:8: warning: initialization from incompatible pointer type [enabled by default] > drivers/net/ethernet/wiznet/w5300.c:708:8: warning: (near initialization for ‘w5300_pm_ops.suspend’) [enabled by default] > drivers/net/ethernet/wiznet/w5300.c:708:8: warning: initialization from incompatible pointer type [enabled by default] > drivers/net/ethernet/wiznet/w5300.c:708:8: warning: (near initialization for ‘w5300_pm_ops.resume’) [enabled by default] > drivers/net/ethernet/wiznet/w5300.c:708:8: warning: initialization from incompatible pointer type [enabled by default] > drivers/net/ethernet/wiznet/w5300.c:708:8: warning: (near initialization for ‘w5300_pm_ops.freeze’) [enabled by default] > drivers/net/ethernet/wiznet/w5300.c:708:8: warning: initialization from incompatible pointer type [enabled by default] > drivers/net/ethernet/wiznet/w5300.c:708:8: warning: (near initialization for ‘w5300_pm_ops.thaw’) [enabled by default] > drivers/net/ethernet/wiznet/w5300.c:708:8: warning: initialization from incompatible pointer type [enabled by default] > drivers/net/ethernet/wiznet/w5300.c:708:8: warning: (near initialization for ‘w5300_pm_ops.poweroff’) [enabled by default] > drivers/net/ethernet/wiznet/w5300.c:708:8: warning: initialization from incompatible pointer type [enabled by default] > drivers/net/ethernet/wiznet/w5300.c:708:8: warning: (near initialization for ‘w5300_pm_ops.restore’) [enabled by default] > > It seems that the arguments and return types for these operations have > changed since you worked on these patches, but this should be easy > to fix up. > > Please cure these two issues and I'll happily put these new drivers > into net-next, and meanwhile you can continue to work with Eric > Dumazet to correct the TX flow control and locking issues. > > Thanks.
Fixed and posted v9.
Thanks.
-- Mike
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |