lkml.org 
[lkml]   [2012]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb: host: tegra: re-arranging ehci functions
On Thu, 5 Apr 2012, Venu Byravarasu wrote:

> Re-arranged standard and tegra specific ehci functions
> into two separate groups, for more readability
>
> Signed-off-by: Venu Byravarasu <vbyravarasu@nvidia.com>
> ---
> drivers/usb/host/ehci-tegra.c | 23 ++++++++++++-----------
> 1 files changed, 12 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
> index 3de48a2..96c942c 100644
> --- a/drivers/usb/host/ehci-tegra.c
> +++ b/drivers/usb/host/ehci-tegra.c
> @@ -552,31 +552,32 @@ static const struct hc_driver tegra_ehci_hc_driver = {
> .description = hcd_name,
> .product_desc = "Tegra EHCI Host Controller",
> .hcd_priv_size = sizeof(struct ehci_hcd),
> -
> .flags = HCD_USB2 | HCD_MEMORY,
>
> - .reset = tegra_ehci_setup,
> - .irq = ehci_irq,
> -
> + /* standard ehci functions */
> .start = ehci_run,
> .stop = ehci_stop,
> - .shutdown = tegra_ehci_shutdown,
> - .urb_enqueue = ehci_urb_enqueue,
> .urb_dequeue = ehci_urb_dequeue,
> - .map_urb_for_dma = tegra_ehci_map_urb_for_dma,
> - .unmap_urb_for_dma = tegra_ehci_unmap_urb_for_dma,
> .endpoint_disable = ehci_endpoint_disable,
> .endpoint_reset = ehci_endpoint_reset,
> .get_frame_number = ehci_get_frame,
> .hub_status_data = ehci_hub_status_data,
> - .hub_control = tegra_ehci_hub_control,
> .clear_tt_buffer_complete = ehci_clear_tt_buffer_complete,
> + .relinquish_port = ehci_relinquish_port,
> + .port_handed_over = ehci_port_handed_over,
> +
> + /* modified ehci functions for tegra */
> + .reset = tegra_ehci_setup,
> + .irq = tegra_ehci_irq,

What happened here? This patch is supposed to rearrange the entries,
not change them.

> + .shutdown = tegra_ehci_shutdown,
> + .map_urb_for_dma = tegra_ehci_map_urb_for_dma,
> + .unmap_urb_for_dma = tegra_ehci_unmap_urb_for_dma,
> + .hub_control = tegra_ehci_hub_control,
> + .urb_enqueue = tegra_ehci_urb_enqueue,

Same here.

> #ifdef CONFIG_PM
> .bus_suspend = tegra_ehci_bus_suspend,
> .bus_resume = tegra_ehci_bus_resume,
> #endif
> - .relinquish_port = ehci_relinquish_port,
> - .port_handed_over = ehci_port_handed_over,
> };

Alan Stern



\
 
 \ /
  Last update: 2012-04-05 16:09    [W:0.038 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site