lkml.org 
[lkml]   [2012]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] gpio: Device tree support for LPC32xx
Date
On Tuesday 03 April 2012, Roland Stigge wrote:
> This patch adds device tree support for gpio-lpc32xx.c
>
> Signed-off-by: Roland Stigge <stigge@antcom.de>

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

Just one more comment:

> +#ifdef CONFIG_OF
> +static struct of_device_id lpc32xx_gpio_of_match[] __devinitdata = {
> + { .compatible = "nxp,lpc32xx-gpio", },
> + { },
> +};
> +#endif
> +
> +static struct platform_driver lpc32xx_gpio_driver = {
> + .driver = {
> + .name = "lpc32xx-gpio",
> + .owner = THIS_MODULE,
> + .of_match_table = lpc32xx_gpio_of_match,
> + },
> + .probe = lpc32xx_gpio_probe,
> +};

The #ifdef above is not helpful, it will cause a build error in the
of_match_table= assignment. Since the plan for this driver is to
be devicetree-only, it would be appropriate to just remove the
#ifdef, but adding of_match_ptr() is ok too.

Arnd



\
 
 \ /
  Last update: 2012-04-04 12:29    [W:0.065 / U:1.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site