Messages in this thread Patch in this message | | | Date | Wed, 4 Apr 2012 12:13:00 +0300 | From | Shmulik Ladkani <> | Subject | [PATCH] ipv6: Fix 'inet6_rtm_getroute' to release 'rt->dst' in case of 'alloc_skb' failure |
| |
In 72331bc [ipv6: Fix RTM_GETROUTE's interpretation of RTA_IIF to be consistent with ipv4] the code of 'inet6_rtm_getroute()' was re-ordered such that the reference to 'rt->dst' is incremented prior skb allocation.
Hence, if 'alloc_skb()' fails, must drop a reference from 'rt->dst'. Add the missing 'dst_release()' call.
Signed-off-by: Shmulik Ladkani <shmulik.ladkani@gmail.com> --- diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 1178345..00b987c 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -2581,6 +2581,7 @@ static int inet6_rtm_getroute(struct sk_buff *in_skb, struct nlmsghdr* nlh, void skb = alloc_skb(NLMSG_GOODSIZE, GFP_KERNEL); if (!skb) { + dst_release(&rt->dst); err = -ENOBUFS; goto errout; }
| |