Messages in this thread | | | Date | Wed, 4 Apr 2012 17:33:21 -0700 | From | Greg Kroah-Hartmann <> | Subject | Re: [PATCH] printk: support structured and multi-facility log messages |
| |
On Wed, Apr 04, 2012 at 04:51:20PM -0700, Joe Perches wrote: > On Wed, 2012-04-04 at 21:59 +0200, Kay Sievers wrote: > > From: Kay Sievers <kay@vrfy.org> > > Subject: printk: support structured and multi-facility log messages > [] > > This patch extends printk() to be able to attach arbitrary key/value > > pairs to logged messages, > > How does it do that?
The implementation doesn't show that?
> [] > > > - Records consume almost the same amount, sometimes less memory than > > the traditional byte stream buffer (if printk_time is enabled). The record > > header is 16 bytes long, plus some padding bytes at the end if needed. > > The byte-stream buffer needed 3 chars for the syslog prefix, 15 char for > > the timestamp and a newline. > > I suggest using lzo on the string portion.
As the used overall size is pretty much the same, that doesn't really seem necessary to me.
thanks,
greg k-h
| |