Messages in this thread | | | Date | Wed, 04 Apr 2012 13:08:04 +0200 | From | Roland Stigge <> | Subject | Re: [PATCH v2] gpio: Device tree support for LPC32xx |
| |
On 04/04/2012 10:48 AM, Arnd Bergmann wrote: >> +#ifdef CONFIG_OF >> +static struct of_device_id lpc32xx_gpio_of_match[] __devinitdata = { >> + { .compatible = "nxp,lpc32xx-gpio", }, >> + { }, >> +}; >> +#endif >> + >> +static struct platform_driver lpc32xx_gpio_driver = { >> + .driver = { >> + .name = "lpc32xx-gpio", >> + .owner = THIS_MODULE, >> + .of_match_table = lpc32xx_gpio_of_match, >> + }, >> + .probe = lpc32xx_gpio_probe, >> +}; > > The #ifdef above is not helpful, it will cause a build error in the > of_match_table= assignment. Since the plan for this driver is to > be devicetree-only, it would be appropriate to just remove the > #ifdef, but adding of_match_ptr() is ok too.
I think I just forgot the of_match_ptr(). Will post an update with a repo for gpio to pull from.
Thanks for the note!
Roland
| |