Messages in this thread | | | Date | Mon, 30 Apr 2012 17:34:45 -0700 | Subject | Re: [PATCH -v11 05/30] PCI: Add busn_res operation functions | From | Yinghai Lu <> |
| |
On Mon, Apr 30, 2012 at 4:29 PM, Bjorn Helgaas <bhelgaas@google.com> wrote: > On Sun, Mar 18, 2012 at 11:42 PM, Yinghai Lu <yinghai@kernel.org> wrote: >> +void pci_bus_update_busn_res_end(struct pci_bus *b, int bus_max) >> +{ >> + struct resource *res = &b->busn_res; >> + struct resource old_res = *res; >> + >> + res->end = bus_max; > > I've mentioned before that I'm not comfortable with updating the > struct resource after it's been inserted into the tree. If you want > to do an in-place update, I think you need to add a new interface in > kernel/resource.c so it can make sure the resource tree remains > consistent.
ok, will add one function in kernel/resource.c to make sure that end could be updated safely by checking parent and children. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |