Messages in this thread | | | Date | Mon, 30 Apr 2012 16:06:25 +0900 | From | Minchan Kim <> | Subject | vmevent: question? |
| |
Hi Pekka,
I looked into vmevent and have few questions.
vmevent_smaple gathers all registered values to report to user if vmevent match. But the time gap between vmevent match check and vmevent_sample_attr could make error so user could confuse.
Q 1. Why do we report _all_ registered vmstat value? In my opinion, it's okay just to report _a_ value vmevent_match happens. Q 2. Is it okay although value when vmevent_match check happens is different with vmevent_sample_attr in vmevent_sample's for loop? I think it's not good. Q 3. Do you have any plan to change getting value's method? Now it's IRQ context so we have limitation to get a vmstat values so that It couldn't be generic. IMHO, To merge into mainline, we should solve this problem. Q 4. Do you have any plan for this patchset to merge into mainline?
Thanks.
-- Kind regards, Minchan Kim
| |