Messages in this thread | | | Date | Mon, 30 Apr 2012 19:19:41 +0300 | From | "Kirill A. Shutemov" <> | Subject | Re: [PATCH] hwmon: coretemp: fix oops on cpu unplug |
| |
On Mon, Apr 30, 2012 at 08:28:10AM -0700, Guenter Roeck wrote: > Hi, > > good catch. Couple of problems, though. > > First, what number of cores are we talking about ? We should probably > increase NUM_REAL_CORES as well. Long term, we should get rid of the > dependency to prevent that problem from happening again, but that is a > different issue.
It triggered by another bug. Cores on my 10-core processor have ids 0, 1, 2, 8, 9, 16, 17, 18, 24, 25. :-/ No need to change NUM_REAL_CORES at the moment.
> Second, we'll need the same code in get_core_online(). Otherwise the > platform device can be created for the new core (if the core is > re-enabled) but will never be deleted.
It has already handled in create_core_data().
-- Kirill A. Shutemov
| |