lkml.org 
[lkml]   [2012]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sysfs: Redundant assignment of dup_name in sysfs_rename
On Fri, Apr 27, 2012 at 08:01:02PM +0530, Sasikantha babu wrote:
> It is redundant to assign "kstrdup" of "new_value" to "dup_name",
> Since we are overwriting "dup_name" with "sd->s_name"
>
> Signed-off-by: Sasikantha babu <sasikanth.v19@gmail.com>
> ---
> fs/sysfs/dir.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c
> index 35a36d3..4abd424 100644
> --- a/fs/sysfs/dir.c
> +++ b/fs/sysfs/dir.c
> @@ -875,7 +875,7 @@ int sysfs_rename(struct sysfs_dirent *sd,
> /* rename sysfs_dirent */
> if (strcmp(sd->s_name, new_name) != 0) {
> error = -ENOMEM;
> - new_name = dup_name = kstrdup(new_name, GFP_KERNEL);
> + new_name = kstrdup(new_name, GFP_KERNEL);
> if (!new_name)
> goto out;

Why not get rid of dup_name entirely now as it really isn't used at all?
That would make a more "complete" patch, care to redo this?

greg k-h


\
 
 \ /
  Last update: 2012-04-30 08:01    [W:0.035 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site