Messages in this thread | | | Date | Mon, 30 Apr 2012 08:46:07 -0300 | From | Mauro Carvalho Chehab <> | Subject | Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers |
| |
Em 30-04-2012 08:15, Borislav Petkov escreveu: > On Mon, Apr 30, 2012 at 08:09:20AM -0300, Mauro Carvalho Chehab wrote: >>> you guys are so trigger-happy to apply humongous, cleanup patches but >>> let me ask this: can anyone of you really test those changes with each >>> driver? Do you have all the hardware that those patches touch? >> >> Well, then why you've touched that in the first place, without even looking >> what would be affected at the EDAC core and at the drivers? Didn't you tested >> it on all hardware that your patch affected? > > Because I simply missed that fact, which is my bad, sorry. > >> This patch touches only on debug code that aren't even enabled on >> production kernels. Assuming that a sneaky bug were introduced, this >> won't cause much hurt, and any developer inspecting those debug >> messages will be able to discover and fix what happened there. > > Ok, fine, I still will review the amd64_edac side of the changes. >
Ok, Thanks! Mauro
| |