lkml.org 
[lkml]   [2012]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] tilepro ethernet driver: fix a few minor issues
From
From: Chris Metcalf <cmetcalf@tilera.com>
Date: Fri, 30 Mar 2012 19:23:35 -0400

> This commit fixes a number of issues seen with the driver:
>
> - Improve handling of return credits to the hardware shim
> - Use skb_frag_size() appropriately
> - Add netpoll support to run console over UDP
>
> Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>

Please do not mix pure bug fixes and new features.

Submit the pure bug fixes separately for 'net' tree submission
and then submit feature additions like netpoll support in
a patch targetting the 'net-next' tree.

> + /* Handle completions if needed to make room. */
> + /* NOTE: Return NETDEV_TX_BUSY if there is still no room. */

Do not format comments like this, use something like this instead:

/* Handle completions if needed to make room.
* NOTE: Return NETDEV_TX_BUSY if there is still no room.
*/

> /* Prepare to advance, detecting full queue. */
> + /* NOTE: Return NETDEV_TX_BUSY if the queue is full. */

Similarly, combine them up into a single comment.

> + /* Handle completions if needed to make room. */
> + /* NOTE: Return NETDEV_TX_BUSY if there is still no room. */

Same here.

> /* Copy the commands, or fail. */
> + /* NOTE: Return NETDEV_TX_BUSY if the queue is full. */

Again.

> +#ifdef CONFIG_NET_POLL_CONTROLLER
> +/*
> + * Polling 'interrupt' - used by things like netconsole to send skbs

Format the comment:

/* Like
* this.
*/

not:

/*
* Like
* this.
*/


\
 
 \ /
  Last update: 2012-04-04 00:25    [W:1.383 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site