Messages in this thread | | | Date | Tue, 3 Apr 2012 21:58:32 +0100 | From | Alan Cox <> | Subject | Re: [PATCH 1/2] 8250_pci: Replace commits 448ac154 and e86ff4a |
| |
On Tue, 3 Apr 2012 12:43:20 -0700 sudhakar <sudhakar@fb.com> wrote:
> > From: Sudhakar Mamillapalli <sudhakar@fb.com> > > > The following commits don't completely fix the KT serial missing > interrupt problems. So they have been replaced instead by > enabling serial backup timer. The iir-once + msi tried approach tried > to enforce one read of the iir per THRE event, but its defeated by any > other event occurring at the wrong time, particularly MSR events. > > 448ac15 serial/8250_pci: setup-quirk workaround for the kt serial controller > e86ff4a serial/8250_pci: init-quirk msi support for kt serial controller
These are already in tree. If you are reversing them and adding a different fix then please post the series as
- two revert patches exactly reverting the two commits - a follow on patch or two adding the replacement
That makes it much easier to review and much more obvious. It also helps make testing simpler.
Alan
| |