Messages in this thread | | | From | Linus Torvalds <> | Date | Sun, 29 Apr 2012 18:56:26 -0700 | Subject | Re: autofs: make the autofsv5 packet file descriptor use a packetized pipe |
| |
On Sun, Apr 29, 2012 at 6:29 PM, Ian Kent <raven@themaw.net> wrote: > > autodir looks ok as well. > > http://sourceforge.net/projects/intraperson/files/latest/download
That looks odd, but safe.
Why does the code make the pipe file descriptor non-blocking, when it then always reads it using that odd "poll_read()" function that does a loop with poll() and read(). I guess there is some 1-second timeout thing.
It's a bit odd in other ways too. The "handle_events()" function is passed the fd, but then it never actually uses it, and uses 'autodir.k_pipe' instead.
So I'm having a bit of trouble following the *logic* to any of that, but the only reads I found did seem to match the "read whole packet" model, so it does look ok too.
Linus
| |