Messages in this thread | | | Date | Thu, 26 Apr 2012 10:47:03 +0200 | Subject | Some kerneldoc:s maybe? | From | Linus Walleij <> |
| |
Hi Stephen,
could you have a look at this from <linux/pinctrl.h>:
/** * struct pinctrl_ops - global pin control operations, to be implemented by * pin controller drivers. * @get_groups_count: Returns the count of total number of groups registered. * @get_group_name: return the group name of the pin group * @get_group_pins: return an array of pins corresponding to a certain * group selector @pins, and the size of the array in @num_pins * @pin_dbg_show: optional debugfs display hook that will provide per-device * info for a certain pin in debugfs */ struct pinctrl_ops { int (*get_groups_count) (struct pinctrl_dev *pctldev); const char *(*get_group_name) (struct pinctrl_dev *pctldev, unsigned selector); int (*get_group_pins) (struct pinctrl_dev *pctldev, unsigned selector, const unsigned **pins, unsigned *num_pins); void (*pin_dbg_show) (struct pinctrl_dev *pctldev, struct seq_file *s, unsigned offset); int (*dt_node_to_map) (struct pinctrl_dev *pctldev, struct device_node *np_config, struct pinctrl_map **map, unsigned *num_maps); void (*dt_free_map) (struct pinctrl_dev *pctldev, struct pinctrl_map *map, unsigned num_maps); };
I'm missing kerneldoc for dt_node_to_map() and dt_free_map(), could you file a patch with some doc? I think you're the only in-kernel user and wrote them so you'd know what to put there.
Would be much appreaciated.
Yours, Linus Walleij
| |