lkml.org 
[lkml]   [2012]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/4] perf annotate browser: Don't draw jump connectors for out of function jumps
    Date
    From: Arnaldo Carvalho de Melo <acme@redhat.com>

    As described in the previous patch. Next step is to properly label those
    jumps by using a -> arrow, i.e. not backwards/forwards, and allow the
    user to navigate to this other function when enter or -> is pressed.

    Cc: David Ahern <dsahern@gmail.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Namhyung Kim <namhyung@gmail.com>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Link: http://lkml.kernel.org/n/tip-ax2sss463eu88wgl9ee8a6b6@git.kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/ui/browsers/annotate.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
    index 73e1ef0..077380b 100644
    --- a/tools/perf/ui/browsers/annotate.c
    +++ b/tools/perf/ui/browsers/annotate.c
    @@ -153,7 +153,8 @@ static void annotate_browser__draw_current_loop(struct ui_browser *browser)
    unsigned int from, to, start_width = 2;

    list_for_each_entry_from(pos, &notes->src->source, node) {
    - if (!pos->ins || !ins__is_jump(pos->ins))
    + if (!pos->ins || !ins__is_jump(pos->ins) ||
    + !disasm_line__has_offset(pos))
    continue;

    target = ab->offsets[pos->ops.target.offset];
    @@ -689,7 +690,8 @@ static void annotate_browser__mark_jump_targets(struct annotate_browser *browser
    struct disasm_line *dl = browser->offsets[offset], *dlt;
    struct browser_disasm_line *bdlt;

    - if (!dl || !dl->ins || !ins__is_jump(dl->ins))
    + if (!dl || !dl->ins || !ins__is_jump(dl->ins) ||
    + !disasm_line__has_offset(dl))
    continue;

    if (dl->ops.target.offset >= size) {
    --
    1.7.9.2.358.g22243


    \
     
     \ /
      Last update: 2012-04-26 17:09    [W:4.023 / U:0.264 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site