Messages in this thread | | | Date | Thu, 26 Apr 2012 07:17:25 -0700 | Subject | Re: Default Kconfig state for hw_random drivers | From | Olof Johansson <> |
| |
On Thu, Apr 26, 2012 at 4:42 AM, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote: > An Atmel hw_random driver just appeared in -next. Since it's just a > regular platform device it has no dependencies on any particular > platform so following the behaviour of other hw_random drivers it's set > to default enabled if hw_random is enabled, even on non-Atmel platforms. > > This doesn't feel like the right thing to do - it'd mean that most of > the embedded RNGs would end up getting enabled by default which probably > isn't what we want.
Indeed, thanks for catching this. The driver isn't new but it had a previous dependency on just one AT91 chip family.
Looking at other options in the same Kconfig, it would be appropriate to make it depend on ARCH_AT91 instead.
Nicolas?
-Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |