Messages in this thread | | | Date | Thu, 26 Apr 2012 15:29:38 +0200 (CEST) | From | Jan Engelhardt <> | Subject | Re: [PATCH RFC tip/core/rcu 5/6] rcu: Make __kfree_rcu() less dependent on compiler choices |
| |
On Thursday 2012-04-26 14:48, Peter Zijlstra wrote: >On Mon, 2012-04-23 at 09:42 -0700, Paul E. McKenney wrote: >> Currently, __kfree_rcu() is implemented as an inline function, and >> contains a BUILD_BUG_ON() that malfunctions if __kfree_rcu() is compiled >> as an out-of-line function. Unfortunately, there are compiler settings >> (e.g., -O0) that can result in __kfree_rcu() being compiled out of line, >> resulting in annoying build breakage. This commit therefore converts >> both __kfree_rcu() and __is_kfree_rcu_offset() from inline functions to >> macros to prevent such misbehavior on the part of the compiler. > >The kernel very explicitly doesn't support being compiled with -O0, so >this is a non-issue, I think you can make it work if you add >-finline-functions. > >I'd drop this, either make the entire kernel compile or don't bother.
It was not originally meant to make the entire kernel compile with -O0, but only select modules/.c files. That, or __always_inline just does not always inline.
| |