Messages in this thread | | | Subject | Re: 3.4-rc3 compile failed on IBM Power6 | From | Benjamin Herrenschmidt <> | Date | Wed, 25 Apr 2012 14:10:42 +1000 |
| |
On Wed, 2012-04-25 at 09:50 +0800, Gavin Shan wrote: > In order to make iommu.c irrelative to CONFIG_EEH, we might figure out > the PE number of the PCI device during PCI probe time. Here're some > rough thoughts about the rework. > > - Introduce additional field "int pe_num" to "struct dev_archdata". > That would be traced like: (struct pci_dev)->(struct device dev) > ->(struct dev_archdata archdata). > - During the PCI probe time (maybe pci_fixup_early), we can figure > out the PE number. > > Then we can retrieve the PE number of PCI device from "int pe_num" and needn't > care CONFIG_EEH has been turned on or off. I'm not sure Ben has any comments > on the idea?
Just select EEH from pseries Kconfig, no point in keeping that a user visible option.
Cheers, Ben.
| |