Messages in this thread | | | Date | Wed, 25 Apr 2012 15:42:45 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [BUG]memblock: fix overflow of array index |
| |
On 04/25/2012 03:31 PM, David Miller wrote: > From: "H. Peter Anvin" <hpa@linux.intel.com> > Date: Wed, 25 Apr 2012 15:29:31 -0700 > >> On 04/25/2012 03:28 PM, Tejun Heo wrote: >>> >>> All indexes in memblock are integers. Changing that particular one to >>> unsigned int doesn't fix anything. I think it just makes things more >>> confusing. If there ever are cases w/ more then 2G memblocks, we're >>> going for 64bit not unsigned. >>> >> >> I would expect there to be plenty of memblocks larger than 2G? > > Yes, but not the array indexes into those memblock entries, which is > what this patch is about.
OIC... more than 2^31 memblocks.
-hpa
| |