Messages in this thread | | | Date | Wed, 25 Apr 2012 15:28:19 -0700 | From | Tejun Heo <> | Subject | Re: [BUG]memblock: fix overflow of array index |
| |
On Wed, Apr 25, 2012 at 04:30:19PM +0800, Peter Teoh wrote: > Fixing the mismatch in signed and unsigned type assignment, which > potentially can lead to integer overflow bug. > > Thanks. > > Reviewed-by: Minchan Kim <minchan@kernel.org> > Signed-off-by: Peter Teoh <htmldeveloper@gmail.com>
All indexes in memblock are integers. Changing that particular one to unsigned int doesn't fix anything. I think it just makes things more confusing. If there ever are cases w/ more then 2G memblocks, we're going for 64bit not unsigned.
Thanks.
-- tejun
| |