lkml.org 
[lkml]   [2012]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/6] ext4: Remove i_mutex use from ext4_quota_write()
    Date
    We don't need i_mutex in ext4_quota_write() because writes to quota file
    are serialized by dqio_mutex anyway. Changes to quota files outside of quota
    code are forbidded and enforced by NOATIME and IMMUTABLE bits.

    Signed-off-by: Jan Kara <jack@suse.cz>
    ---
    fs/ext4/super.c | 6 +-----
    1 files changed, 1 insertions(+), 5 deletions(-)

    diff --git a/fs/ext4/super.c b/fs/ext4/super.c
    index 6da1935..14965ca 100644
    --- a/fs/ext4/super.c
    +++ b/fs/ext4/super.c
    @@ -4742,7 +4742,6 @@ static ssize_t ext4_quota_write(struct super_block *sb, int type,
    return -EIO;
    }

    - mutex_lock_nested(&inode->i_mutex, I_MUTEX_QUOTA);
    bh = ext4_bread(handle, inode, blk, 1, &err);
    if (!bh)
    goto out;
    @@ -4758,16 +4757,13 @@ static ssize_t ext4_quota_write(struct super_block *sb, int type,
    err = ext4_handle_dirty_metadata(handle, NULL, bh);
    brelse(bh);
    out:
    - if (err) {
    - mutex_unlock(&inode->i_mutex);
    + if (err)
    return err;
    - }
    if (inode->i_size < off + len) {
    i_size_write(inode, off + len);
    EXT4_I(inode)->i_disksize = inode->i_size;
    ext4_mark_inode_dirty(handle, inode);
    }
    - mutex_unlock(&inode->i_mutex);
    return len;
    }

    --
    1.7.1


    \
     
     \ /
      Last update: 2012-04-25 23:03    [W:4.417 / U:0.380 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site