Messages in this thread Patch in this message | | | From | Stephen Warren <> | Subject | [PATCH] pinctrl: propagate map validation errors | Date | Wed, 25 Apr 2012 10:32:16 -0600 |
| |
From: Stephen Warren <swarren@nvidia.com>
pinctrl_register_map() was returning early if pinmux_validate_map() or pinconf_validate_map() failed, but was not actually returning the error code.
Signed-off-by: Stephen Warren <swarren@nvidia.com> --- drivers/pinctrl/core.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index 5cd5a5a..913c83e 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -911,13 +911,13 @@ int pinctrl_register_map(struct pinctrl_map const *maps, unsigned num_maps, case PIN_MAP_TYPE_MUX_GROUP: ret = pinmux_validate_map(&maps[i], i); if (ret < 0) - return 0; + return ret; break; case PIN_MAP_TYPE_CONFIGS_PIN: case PIN_MAP_TYPE_CONFIGS_GROUP: ret = pinconf_validate_map(&maps[i], i); if (ret < 0) - return 0; + return ret; break; default: pr_err("failed to register map %s (%d): invalid type given\n", -- 1.7.0.4
| |