Messages in this thread | | | Date | Wed, 25 Apr 2012 16:40:32 +0200 | Subject | Re: [PATCH 2/4] bug: completely remove code of disabled VM_BUG_ON() | From | Geert Uytterhoeven <> |
| |
On Wed, Apr 25, 2012 at 13:26, Konstantin Khlebnikov <khlebnikov@openvz.org> wrote: > Even if CONFIG_DEBUG_VM=n gcc genereates code for some VM_BUG_ON()
That's because of the side effects of the expression
https://lkml.org/lkml/2012/4/25/146
But IRIC, we do want them here?
> bloat-o-meter: add/remove: 0/1 grow/shrink: 10/120 up/down: 185/-1889 (-1704) > > Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org> > --- > include/linux/mmdebug.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h > index c04ecfe..9c9a2a0 100644 > --- a/include/linux/mmdebug.h > +++ b/include/linux/mmdebug.h > @@ -4,7 +4,7 @@ > #ifdef CONFIG_DEBUG_VM > #define VM_BUG_ON(cond) BUG_ON(cond) > #else > -#define VM_BUG_ON(cond) do { (void)(cond); } while (0) > +#define VM_BUG_ON(cond) unused_expression(cond) > #endif > > #ifdef CONFIG_DEBUG_VIRTUAL
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |