lkml.org 
[lkml]   [2012]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [ibm-acpi-devel] [PATCH] thinkpad-acpi: fix issuing duplicated key events for brightness up/down
On 04/24/2012 04:40 PM, Alex Hung wrote:
> The tp_features.bright_acpimode will not be set correctly for brightness
> control because ACPI_VIDEO_HID will not be located in ACPI. As a result,
> a duplicated key event will always be sent. acpi_video_backlight_support()
> is sufficient to detect standard ACPI brightness control.
>
> Signed-off-by: Alex Hung<alex.hung@canonical.com>
> ---
> drivers/platform/x86/thinkpad_acpi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index 7b82868..7d032d5 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -3405,7 +3405,7 @@ static int __init hotkey_init(struct ibm_init_struct *iibm)
> /* Do not issue duplicate brightness change events to
> * userspace. tpacpi_detect_brightness_capabilities() must have
> * been called before this point */
> - if (tp_features.bright_acpimode&& acpi_video_backlight_support()) {
> + if (acpi_video_backlight_support()) {
> pr_info("This ThinkPad has standard ACPI backlight "
> "brightness control, supported by the ACPI "
> "video driver\n");

Hi,
I tested the patch on thinkpad x200 and x220, and the brightness up/down
key presses will no longer generate a duplicated event, i.e. output from
"sudo showkey".

Best Regards,
Alex Hung


\
 
 \ /
  Last update: 2012-04-24 10:47    [W:0.043 / U:1.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site