Messages in this thread | | | Date | Tue, 24 Apr 2012 16:46:17 +0800 | From | Dong Aisheng <> | Subject | Re: [PATCH 3/3] ARM: imx6q: switch to use pinctrl driver |
| |
On Tue, Apr 24, 2012 at 04:23:34PM +0800, Linus Walleij wrote: > On Mon, Apr 16, 2012 at 5:35 AM, Dong Aisheng > <aisheng.dong@freescale.com> wrote: > > On Sun, Apr 15, 2012 at 03:37:54PM +0800, Shawn Guo wrote: > >> On Sun, Apr 15, 2012 at 12:03:16PM +0800, Dong Aisheng wrote: > >> ... > >> > For MX3 and MX5, before their pinctrl driver are available, user may > >> > need to define a dummy in dt to avoid such an error. > >> > > >> That is insane, and will not work. > >> > >> 1) We do not have device tree support for MX3 yet. > >> 2) It's not practical to add dummy entries in dt to avoid the error. > >> 3) There are still so many non-dt board files support in the tree. > >> How will they work with that? > >> > >> My suggestion is to not make it an error but a dev_dbg, assuming that > >> the pins are already set up by platform code if we do not find the > >> entry from pinctrl system. We can take it as a transition solution, > >> and turn the dev_dbg back to error when all the users of the device > >> driver are converted to device tree. > >> > > My thinking is let pinctrl core handle dummy state as regulator subsystem > > and does not depend on dt. > > Linus, Stephen, any comment? > > I think this was discussed in another thread and Sascha agreed that > wee need dummy pinctrl to copy with a smooth transition in i.MX. > > So I'm happy with that, we just need to finalize a patch, poke > me if I missed some patch... > I'm revising that patch based on your suggestion, will send out soon. :-)
Regards Dong Aisheng
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |