lkml.org 
[lkml]   [2012]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 08/42] USB: yurex: Remove allocation of coherent buffer for setup-packet buffer
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Tomoki Sekiyama <tomoki.sekiyama@gmail.com>

    commit 523fc5c14f6cad283e5a266eba0e343aed6e73d5 upstream.

    Removes allocation of coherent buffer for the control-request setup-packet
    buffer from the yurex driver. Using coherent buffers for setup-packet is
    obsolete and does not work with some USB host implementations.

    Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/misc/yurex.c | 8 ++------
    1 file changed, 2 insertions(+), 6 deletions(-)

    --- a/drivers/usb/misc/yurex.c
    +++ b/drivers/usb/misc/yurex.c
    @@ -99,9 +99,7 @@ static void yurex_delete(struct kref *kr
    usb_put_dev(dev->udev);
    if (dev->cntl_urb) {
    usb_kill_urb(dev->cntl_urb);
    - if (dev->cntl_req)
    - usb_free_coherent(dev->udev, YUREX_BUF_SIZE,
    - dev->cntl_req, dev->cntl_urb->setup_dma);
    + kfree(dev->cntl_req);
    if (dev->cntl_buffer)
    usb_free_coherent(dev->udev, YUREX_BUF_SIZE,
    dev->cntl_buffer, dev->cntl_urb->transfer_dma);
    @@ -234,9 +232,7 @@ static int yurex_probe(struct usb_interf
    }

    /* allocate buffer for control req */
    - dev->cntl_req = usb_alloc_coherent(dev->udev, YUREX_BUF_SIZE,
    - GFP_KERNEL,
    - &dev->cntl_urb->setup_dma);
    + dev->cntl_req = kmalloc(YUREX_BUF_SIZE, GFP_KERNEL);
    if (!dev->cntl_req) {
    err("Could not allocate cntl_req");
    goto error;



    \
     
     \ /
      Last update: 2012-04-25 00:49    [W:4.154 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site