lkml.org 
[lkml]   [2012]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 27/42] ext4: fix endianness breakage in ext4_split_extent_at()
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Al Viro <viro@zeniv.linux.org.uk>

    commit af1584f570b19b0285e4402a0b54731495d31784 upstream.

    ->ee_len is __le16, so assigning cpu_to_le32() to it is going to do
    Bad Things(tm) on big-endian hosts...

    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    Cc: Ted Ts'o <tytso@mit.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ext4/extents.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/ext4/extents.c
    +++ b/fs/ext4/extents.c
    @@ -2846,7 +2846,7 @@ static int ext4_split_extent_at(handle_t
    if (err)
    goto fix_extent_len;
    /* update the extent length and mark as initialized */
    - ex->ee_len = cpu_to_le32(ee_len);
    + ex->ee_len = cpu_to_le16(ee_len);
    ext4_ext_try_to_merge(inode, path, ex);
    err = ext4_ext_dirty(handle, inode, path + depth);
    goto out;



    \
     
     \ /
      Last update: 2012-04-25 00:45    [W:2.274 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site