Messages in this thread | | | Date | Tue, 24 Apr 2012 13:40:31 +0100 | From | Mark Brown <> | Subject | Re: [PATCH V1 2/2] i2c: tegra: support for I2C_M_NOSTART protocol mangling |
| |
On Tue, Apr 24, 2012 at 02:32:41PM +0200, Jean Delvare wrote:
> Please keep in mind that support for I2C_M_NOSTART at the bus driver > level is optional. This means that device drivers are encouraged to not > rely on it unconditionally. Originally the flag was meant to workaround
Yeah, for regmap we certainly have a fallback to kmalloc() a buffer as needed in there already. Like I say it's just an optimisation.
> If you want to do scatter-gather for I2C messages, I understand the > benefit and I have no objection, and I agree that I2C_M_NOSTART lets > you do that, but then:
> * We should allocate a new functionality flag for it. > * We should update the documentation to reflect the two use cases.
That sounds like a good plan. I'll try to get round to it if nobody beats me to it. [unhandled content-type:application/pgp-signature] | |