lkml.org 
[lkml]   [2012]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 03/14 v3] Input: atmel_mxt_ts - refactor mxt_read/write_reg to take a length
    Hi Daniel,

    > The i2c bus requires 5 bytes to do a 1 byte read (1-byte i2c address + 2
    > byte offset + 1-byte i2c address + 1 byte data), or 4 bytes to do a
    > 1-byte write (1 byte i2c address + 2 byte offset + 1 byte data).
    >
    > By taking a length with reads and writes, the driver can amortize
    > transaction overhead by performing larger transactions where appropriate.
    >
    > This patch just sets up the new API. Later patches refactor reads/writes
    > to take advantage of the larger transactions.
    >
    > These functions are also now return any errors reported by the i2c layer.
    >
    > Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
    > ---

    In the cyttsp a dedicate tx buffer is used, which is a bit easier on
    the eyes. OTOH, the write operation seems infrequent enough to not
    matter much, so

    Acked-by: Henrik Rydberg <rydberg@euromail.se>

    Thanks for your patience,
    Henrik


    \
     
     \ /
      Last update: 2012-04-24 13:23    [W:7.380 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site