Messages in this thread Patch in this message | | | Date | Mon, 23 Apr 2012 14:39:48 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 1/1] mmap.c: find_vma: remove unnecessary if(mm) check |
| |
On Sat, 21 Apr 2012 19:12:35 +0530 Rajman Mekaco <rajman.mekaco@gmail.com> wrote:
> The if(mm) check is not required in find_vma, as the kernel > code calls find_vma only when it is absolutely sure that the > mm_struct arg to it is non-NULL. > > Removing the if(mm) check and adding the a WARN_ONCE(!mm) > for now.
Lets do this as well:
--- a/mm/mmap.c~mm-mmapc-find_vma-remove-unnecessary-ifmm-check-fix +++ a/mm/mmap.c @@ -1639,7 +1639,7 @@ struct vm_area_struct *find_vma(struct m { struct vm_area_struct *vma = NULL; - if (WARN_ON_ONCE(!mm)) + if (WARN_ON_ONCE(!mm)) /* Remove this in linux-3.6 */ return NULL; /* Check the cache first. */
| |