Messages in this thread | | | Date | Mon, 23 Apr 2012 13:41:18 -0700 | From | greg <> | Subject | Re: [PATCH 4/4][Trivial] lib/kobject.c : check parameter in kobject_init_and_add |
| |
On Sat, Apr 21, 2012 at 06:17:49PM +0800, yan wrote: > If user turns to the simple interface kobject_init_and_add > and gives a null kobject, kobject_init can detect it but > just dumps the stack. Then there is: > -->kobject_add_varg > -->kobject_set_name_vargs > In the end, it will reference kobj->name and we have an oops. > > Check whether we have a valid kobject in kobject_init_and_add.
Why would anyone ever call this function without a valid kobject?
Again, sorry, this patch isn't ok.
greg k-h
| |